Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Slider] Fix wrong CSS value #42370

Merged
merged 1 commit into from
May 24, 2024

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented May 24, 2024

Fixes #41753

Codesandbox with the fix

@mnajdova mnajdova added bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge labels May 24, 2024
@mui-bot
Copy link

mui-bot commented May 24, 2024

Netlify deploy preview

https://deploy-preview-42370--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c5d9797

@mnajdova mnajdova marked this pull request as ready for review May 24, 2024 09:20
@ZeeshanTamboli ZeeshanTamboli changed the title [Slider] Fix wrong CSS value [material-ui][Slider] Fix wrong CSS value May 24, 2024
@ZeeshanTamboli ZeeshanTamboli added the package: material-ui Specific to @mui/material label May 24, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I also spent few hours on it but couldn't find a solution. 😅 The CodeSandbox you posted doesn't show the fix. Here's the one that does: https://codesandbox.io/p/sandbox/hardcore-napier-3gzxhk.

@mnajdova
Copy link
Member Author

mnajdova commented May 24, 2024

The CodeSandbox you posted doesn't show the fix. Here's the one that does: https://codesandbox.io/p/sandbox/hardcore-napier-3gzxhk.

Aaah, I didn't save the changes, I've udpated the PR description.

@mnajdova mnajdova merged commit a5c5ca9 into mui:next May 24, 2024
23 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material
Projects
None yet
3 participants